Skip to content

Delete faulty assert #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Delete faulty assert #313

merged 1 commit into from
Apr 15, 2025

Conversation

stephentoub
Copy link
Contributor

We need better coverage of Subscribe/Unsubscribe separately, but for now this assert is bad.

Closes #228

@stephentoub
Delete faulty assert
016c99f 
We need better coverage of Subscribe/Unsubscribe separately, but for now this assert is bad.
@stephentoub stephentoub requested a review from halter73 April 15, 2025 15:17
@halter73 halter73 merged commit 90748b1 into modelcontextprotocol:main Apr 15, 2025
7 checks passed
@halter73
Copy link
Contributor

We need better coverage of Subscribe/Unsubscribe separately

Should we keep #228 open to track this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnsubscribeResource_Stdio test is flaky
2 participants
@stephentoub @halter73